[
https://issues.apache.org/jira/browse/AMQ-7493?focusedWorklogId=449324&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449324
]
ASF GitHub Bot logged work on AMQ-7493:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/20 15:01
Start Date: 22/Jun/20 15:01
Worklog Time Spent: 10m
Work Description: jbonofre merged pull request #544:
URL: https://github.com/apache/activemq/pull/544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 449324)
Time Spent: 20m (was: 10m)
> ThreadPoolExecutor in BrokerService throws unneeded exception
> -------------------------------------------------------------
>
> Key: AMQ-7493
> URL: https://issues.apache.org/jira/browse/AMQ-7493
> Project: ActiveMQ
> Issue Type: Task
> Components: Broker
> Reporter: Shmakov Alexey
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 5.16.0, 5.15.14
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hello, i found the bug in
> [https://github.com/apache/activemq/blob/master/activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java#L2859]
>
> {code:java}
> new RejectedExecutionHandler() {
> @Override
> public void rejectedExecution(final Runnable r, final ThreadPoolExecutor
> executor) {
> try{
> executor.getQueue().offer(r, 60, TimeUnit.SECONDS);
> }
> catch (InterruptedException e) {
> throw new RejectedExecutionException("Interrupted waiting for
> BrokerService.worker");
> }
> throw new RejectedExecutionException("Timed Out while attempting to
> enqueue Task.");
> }
> }
> {code}
>
>
> it must be
> {code:java}
> // заполнитель кода
> public void rejectedExecution(final Runnable r, final ThreadPoolExecutor
> executor) {
> try {
> if (!executor.getQueue().offer(r, 60, TimeUnit.SECONDS)) {
> throw new RejectedExecutionException("Timed Out while
> attempting to enqueue Task.");
> }
> }
> catch (InterruptedException e){
> throw new RejectedExecutionException("Interrupted waiting for
> BrokerService.worker");
> }
> }{code}
>
> because on success method offer must return true
> P.s. sorry for my horrible english
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
