[
https://issues.apache.org/jira/browse/ARTEMIS-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153741#comment-17153741
]
ASF subversion and git services commented on ARTEMIS-2801:
----------------------------------------------------------
Commit ffb117d15920fedc7e4246dc4c5881bd1ab47eb9 in activemq-artemis's branch
refs/heads/master from Jan Šmucr
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=ffb117d ]
ARTEMIS-2801 Fix ByteUtil.getHumanReadableByteCount() giving inconsistent
results
HumanReadableByteCountTest test is no longer failing under environments with
locales defining different number format.
The function now returns values according to the Locale.ROOT locale
specification.
> Fix ByteUtil.getHumanReadableByteCount() giving inconsistent results
> --------------------------------------------------------------------
>
> Key: ARTEMIS-2801
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2801
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Tests
> Environment: Windows 10 with cs-CZ locale.
> Reporter: Jan Šmucr
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Original Estimate: 10m
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> HumanReadableByteCountTest test fails in environments with different locale.
> {code:java}
> org.junit.ComparisonFailure:
> Expected :999.0B
> Actual :999,0B
> <Click to see difference>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.activemq.artemis.utils.HumanReadableByteCountTest.test(HumanReadableByteCountTest.java:31)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
