[
https://issues.apache.org/jira/browse/ARTEMIS-2849?focusedWorklogId=460407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-460407
]
ASF GitHub Bot logged work on ARTEMIS-2849:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/20 17:34
Start Date: 17/Jul/20 17:34
Worklog Time Spent: 10m
Work Description: franz1981 commented on a change in pull request #3223:
URL: https://github.com/apache/activemq-artemis/pull/3223#discussion_r456580099
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFile.java
##########
@@ -271,7 +271,7 @@ protected ByteBuffer newBuffer(int size, int limit) {
public void flushBuffer(final ByteBuf byteBuf, final boolean
requestedSync, final List<IOCallback> callbacks) {
final int bytes = byteBuf.readableBytes();
if (bytes > 0) {
- final ByteBuffer buffer = newBuffer(byteBuf.capacity(), bytes);
+ final ByteBuffer buffer = newBuffer(byteBuf.capacity(), bytes,
false);
Review comment:
About the tests: I see that only this one has failed
```
Error Message
expected:<10> but was:<11>
Stacktrace
java.lang.AssertionError: expected:<10> but was:<11>
at
org.apache.activemq.artemis.tests.unit.core.postoffice.impl.DuplicateDetectionUnitTest.testReloadDuplication(DuplicateDetectionUnitTest.java:127)
```
And probably it isn't related
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 460407)
Time Spent: 1h 10m (was: 1h)
> Eliminate zeroing of buffers while writing the ASYNCIO journal
> --------------------------------------------------------------
>
> Key: ARTEMIS-2849
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2849
> Project: ActiveMQ Artemis
> Issue Type: Test
> Components: Broker
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> By default ASYNCIO using TimedBuffer are zeroing the ByteBuffers used to
> perform the write on the journal: under load TimedBuffer can be big enough
> that zeroing would cost the same as copying the actual content into it, hence
> saving the zeroing is quite beneficial to save CPU time and increase IOPS.
> NIO and MAPPED doesn't need it because they already use directly the
> TimedBuffer's accumulation buffer to perform writes (that's never zeroed,
> because it already contains the content that they expect to write into the
> journal), but changing ASYNCIO need to adjust the same calls on NIO and
> MAPPED for completeness.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
