[
https://issues.apache.org/jira/browse/ARTEMIS-2768?focusedWorklogId=490320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-490320
]
ASF GitHub Bot logged work on ARTEMIS-2768:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/20 16:47
Start Date: 24/Sep/20 16:47
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3277:
URL: https://github.com/apache/activemq-artemis/pull/3277#discussion_r494465252
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -3512,7 +3513,14 @@ public Queue createQueue(final QueueConfiguration
queueConfiguration, boolean ig
}
}
- QueueConfigurationUtils.applyDynamicQueueDefaults(queueConfiguration,
addressSettingsRepository.getMatch(getRuntimeTempQueueNamespace(queueConfiguration.isTemporary())
+ queueConfiguration.getAddress().toString()));
+ final AddressSettings addressSettings =
addressSettingsRepository.getMatch(getRuntimeTempQueueNamespace(queueConfiguration.isTemporary())
+ queueConfiguration.getAddress().toString());
+ QueueConfigurationUtils.applyDynamicQueueDefaults(queueConfiguration,
addressSettings);
+
+ if (ActiveMQServerLogger.LOGGER.isEnabled(Logger.Level.WARN)) {
+ if (new AddressImpl(queueConfiguration.getAddress(),
configuration.getWildcardConfiguration()).containsWildCard() &&
addressSettings.getPageStoreName() == null) {
Review comment:
I share that concern, i did not find a way to get the AddressImpl back
from the binding created by the wildcard address manager. It needs some surgery
to access.
The addressImpl has a reference to the wildcard config, I guess I could
duplicate that logic in place of the new ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 490320)
Time Spent: 50m (was: 40m)
> Negative AddressSize in JMX
> ---------------------------
>
> Key: ARTEMIS-2768
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2768
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.11.0, 2.12.0, 2.14.0
> Reporter: Tarek Hammoud
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.16.0
>
> Attachments: TestWildCard.java
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Hello,
> I see negative address size in JMX. This happens when there are two
> consumers. One listening on the full topic name. The other listening on the
> wild card topic. I can easily reproduce with this. [^TestWildCard.java]
> ^Broker shows:^
> ^2020-05-17 09:24:34,826 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-152.^
> ^2020-05-17 09:24:34,827 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-88.^
> ^2020-05-17 09:24:34,828 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-944.^
> ^2020-05-17 09:24:34,828 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-1,800.^
> ^2020-05-17 09:24:34,829 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-1,736.^
> ^2020-05-17 09:24:34,829 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-2,592.^
> ^2020-05-17 09:24:34,829 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-3,448.^
> ^2020-05-17 09:24:34,830 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-4,304.^
> ^2020-05-17 09:24:34,830 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-5,160.^
> ^2020-05-17 09:24:34,830 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-5,096.^
> ^2020-05-17 09:24:34,831 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-5,952.^
> ^2020-05-17 09:24:34,831 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-6,016.^
> ^2020-05-17 09:24:34,832 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-6,080.^
> ^2020-05-17 09:24:34,832 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-6,016.^
> ^2020-05-17 09:24:34,832 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-6,872.^
> ^2020-05-17 09:24:34,832 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-7,728.^
> ^2020-05-17 09:24:34,833 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-8,584.^
> ^2020-05-17 09:24:34,833 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-8,520.^
> ^2020-05-17 09:24:34,833 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-9,376.^
> ^2020-05-17 09:24:34,834 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-10,232.^
> ^2020-05-17 09:24:34,834 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-10,168.^
> ^2020-05-17 09:24:34,834 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-10,104.^
> ^2020-05-17 09:24:34,835 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-10,960.^
> ^2020-05-17 09:24:34,835 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-10,896.^
> ^2020-05-17 09:24:34,836 WARN [org.apache.activemq.artemis.core.server]
> AMQ222214: Destination global.topic.FooBar has an inconsistent and negative
> address size=-10,960.^
> ^2020-05-17 09:24:34,837^
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
