[
https://issues.apache.org/jira/browse/ARTEMIS-2886?focusedWorklogId=495983&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495983
]
ASF GitHub Bot logged work on ARTEMIS-2886:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 15:58
Start Date: 06/Oct/20 15:58
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3254:
URL: https://github.com/apache/activemq-artemis/pull/3254#issuecomment-704379745
Detecting the use of an exact match is important so I wouldn't change that.
I recommend something really simple like this:
```java
validated = ((ActiveMQSecurityManager5) securityManager).authorize(subject,
roles, checkType, fqqn != null ? fqqn.toString() : bareAddress.toString());
```
So instead of using the `isFullyQualified` `boolean` it will just look at
the `fqqn` `SimpleString`. I think that would get you what you want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 495983)
Time Spent: 4h (was: 3h 50m)
> Optimize security auth
> ----------------------
>
> Key: ARTEMIS-2886
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2886
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Both authentication and authorization will hit the underlying security
> repository (e.g. files, LDAP, etc.). For example, creating a JMS connection
> and a consumer will result in 2 hits with the *same* authentication request.
> This can cause unwanted (and unnecessary) resource utilization, especially in
> the case of networked configuration like LDAP.
> There is a rudimentary cache for authorization, but it is cleared *totally*
> every 10 seconds by default (controlled via the
> {{security-invalidation-interval setting}}), and it must be populated
> initially which still results in duplicate auth requests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
