[ 
https://issues.apache.org/jira/browse/ARTEMIS-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212950#comment-17212950
 ] 

Francesco Nigro edited comment on ARTEMIS-2926 at 10/13/20, 9:25 AM:
---------------------------------------------------------------------

That's a good point similar to what [~robbie] has exposed on 
https://github.com/apache/activemq-artemis/pull/3287#issuecomment-707028383: 
agree, we should not measure time on the executor in order to drop executions 
and, better, probably we shouldn't drop execution according to that metric...
And related to the original issue with JDBC: the idea would be to allow to 
start as soon as possible without dropping a "too early" execution, but 
instead, allowing duplicate ones too. Regardless the bug, probably 
ActiveMQScheduledComponent isn't a good fit for that feature as it is.


was (Author: nigrofranz):
That's a good point similar to what [~robbie] has exposed on 
https://github.com/apache/activemq-artemis/pull/3287#issuecomment-707028383: 
agree, we should not measure time on the executor in order to drop executions 
and, better, probably we shouldn't drop execution according to that metric...

> Scheduled task executions are skipped randomly
> ----------------------------------------------
>
>                 Key: ARTEMIS-2926
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2926
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.13.0
>            Reporter: Apache Dev
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Scheduled tasks extending {{ActiveMQScheduledComponent}} could randomly skip 
> an execution, logging:
> {code}
> Execution ignored due to too many simultaneous executions, probably a 
> previous delayed execution
> {code}
> The problem is in the "ActiveMQScheduledComponent#runForExecutor" Runnable.
> Times to be compared ({{currentTimeMillis()}} and {{lastTime}}) are taken 
> inside the runnable execution itself. So, depending on relative execution 
> times, it could happen that the difference is less than the given period 
> (e.g. 1 ms), resulting in a skipped execution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to