[
https://issues.apache.org/jira/browse/ARTEMIS-2949?focusedWorklogId=502701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-502701
]
ASF GitHub Bot logged work on ARTEMIS-2949:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/20 13:53
Start Date: 20/Oct/20 13:53
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3303:
URL: https://github.com/apache/activemq-artemis/pull/3303#discussion_r508523552
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java
##########
@@ -304,6 +339,22 @@ public String toString() {
}
}
+ static final class StoreTaskHolder {
Review comment:
Also add a comment on TaskHolder staying that we are not extending
StoreTaskHolder because of memory optimizations.. as it would use more memory
and this is on the hot path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 502701)
Time Spent: 1h 20m (was: 1h 10m)
> Reduce GC on OperationContext::checkTasks
> -----------------------------------------
>
> Key: ARTEMIS-2949
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2949
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> OperationContext::checkTasks is allocating Iterators that seems not scalar
> replaced and that could be saved by using the Queue API of LinkedList.
> Similarly, store only tasks can use a reduced (in term of footprint) task
> holder to reduce the allocation pressure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
