[
https://issues.apache.org/jira/browse/ARTEMIS-2991?focusedWorklogId=512576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512576
]
ASF GitHub Bot logged work on ARTEMIS-2991:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/20 20:34
Start Date: 16/Nov/20 20:34
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3339:
URL: https://github.com/apache/activemq-artemis/pull/3339#issuecomment-728310654
I don't see any problem with adding getters for testing in this kind of
situation. None of these classes is part of a "public" API. Testing is a
critical part of development and tests should be able to get all the state they
need from a class in order to test it effectively. It's much simpler and
straight-forward to just add the getters instead of using something ugly and
brittle like reflection. Also, mocking is good for a lot things, but we need an
actual integration test here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 512576)
Time Spent: 1h (was: 50m)
> Leak of HttpAcceptorHandler instances when using websocket connections
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-2991
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2991
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0, 2.10.0, 2.10.1, 2.11.0, 2.12.0, 2.13.0, 2.14.0,
> 2.15.0, 2.16.0
> Reporter: Luis Miguel De Bello
> Priority: Major
> Fix For: 2.17.0
>
> Attachments: HeapDump analysis.png
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We are running Artemis 2.9.0 and we noticed the memory grows continuously
> after getting a heap we discovered there are a leak of multiple instances of
> type org.apache.activemq.artemis.core.remoting.impl.netty.HttpAcceptorHandler
> which are keep in a list inside
> org.apache.activemq.artemis.core.remoting.impl.netty.HttpKeepAliveRunnable.
>
> Those instances are removed in the channelInactive method but this method is
> not called because when doing the upgrade to websocket the handler is removed.
>
> Proposals:
> 1) In the upgrade clean up the reference for the HttpAcceptorHandler before
> removing the handler.
> 2) If option 1 does not work because that threads also send the keep alive
> for websocket, I could use the channelInactive from websocket handler to
> later unregister the handler
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
