[ 
https://issues.apache.org/jira/browse/ARTEMIS-2984?focusedWorklogId=514691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514691
 ]

ASF GitHub Bot logged work on ARTEMIS-2984:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Nov/20 16:27
            Start Date: 20/Nov/20 16:27
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #3334:
URL: https://github.com/apache/activemq-artemis/pull/3334#issuecomment-731268700


   @franz1981 what about the previous propose? to make the usage separate? we 
break the API but allow an alternative?
   
   you had a class that you had moved to tests.. all I asked you was to move 
that class to the API.. so if someone is broken by this they could just change 
their code to use this new class.
   
   they are using an internal method.. they would be broken by it.. but at 
least they would have an alternative.
   
   if that's not possible then we can talk about breaking it for sure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 514691)
    Time Spent: 2h 40m  (was: 2.5h)

> Compressed large messages can leak native resources
> ---------------------------------------------------
>
>                 Key: ARTEMIS-2984
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2984
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Compressed large messages use native resources in the form of Inflater and 
> Deflater and should release them in a timely manner (instead of relying on 
> finalization) to save OOM to happen (of direct memory, to be precise).
> This issue has the chance to simplify large message controllers, because much 
> of the existing code on controllers (including compressed one) isn't needed 
> at runtime, but just for testing purposes and a proper fix can move dead code 
> there too, saving leaky behavior to be maintained.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to