[
https://issues.apache.org/jira/browse/ARTEMIS-1925?focusedWorklogId=518911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518911
]
ASF GitHub Bot logged work on ARTEMIS-1925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/20 10:05
Start Date: 02/Dec/20 10:05
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on pull request #2893:
URL: https://github.com/apache/activemq-artemis/pull/2893#issuecomment-737127362
@jbertram
Hmm, I don't really know how to share that in some simple way then...
The reason you are not seeing any change is probably because compared to the
master branch there is no change, it's a revert of that code line from what is
in your original pr back to what master branch is using. So now it looks like
it's on line :489, I changed:
`if ((messageLoadBalancingType.equals(MessageLoadBalancingType.OFF) ||
messageLoadBalancingType.equals(MessageLoadBalancingType.REDISTRIBUTION_ONLY))
&& theBinding instanceof RemoteQueueBinding) {`
back to:
`if (messageLoadBalancingType.equals(MessageLoadBalancingType.OFF) &&
theBinding instanceof RemoteQueueBinding) {`
It's in the fork I shared, but maybe the best would be if I worked from your
new pr and made just this change to that?
Apologies for possibly making this more complicated than it needs to be, I'm
not really used to this workflow.
Br,
Anton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 518911)
Time Spent: 4h (was: 3h 50m)
> Allow message redistribution even with STRICT or OFF message-load-balancing
> semantics
> -------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1925
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Currently if the {{message-load-balancing}} is {{STRICT}} or {{OFF}} then
> message redistribution is disabled. Message redistribution should be
> controlled only by the {{redistribtion-delay}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
