[
https://issues.apache.org/jira/browse/ARTEMIS-3026?focusedWorklogId=522550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-522550
]
ASF GitHub Bot logged work on ARTEMIS-3026:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/20 05:16
Start Date: 10/Dec/20 05:16
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3377:
URL: https://github.com/apache/activemq-artemis/pull/3377#discussion_r539851450
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java
##########
@@ -622,7 +624,15 @@ public long getPersistentSize() throws ActiveMQException {
@Override
public void reencode() {
+ reEncoded = true;
Review comment:
Why isnt the reencoding happening immediately like for other messages
(amqp standard, core etc) and expected behaviour, e.g. other areas of code and
plugins are expecting the message to rencoded by calling this without doing
extra work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 522550)
Time Spent: 1h (was: 50m)
> Allow "reencoding" of application properties on AMQP Large Messages
> -------------------------------------------------------------------
>
> Key: ARTEMIS-3026
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3026
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently if Diverts or other things call amqplargeMessage.reencode() this is
> a moot operation, and there's no way to re-encode the application Properties,
> Properties or anything in the LargeMessage.
>
> It should be possible to allow replacing the application properties upon
> sending.
>
> We save the modified application properties anyways on the journal record.
> So, we should allow ProtonServerSenderContext to replace the original
> application properties by a new set if reencode() is called anywhere on the
> message.
>
> There should be a flag that would be stored as part of the journal allowing
> the broker to know if the message was ever re-encoded.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
