[ 
https://issues.apache.org/jira/browse/ARTEMIS-3045?focusedWorklogId=528462&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-528462
 ]

ASF GitHub Bot logged work on ARTEMIS-3045:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Dec/20 22:05
            Start Date: 25/Dec/20 22:05
    Worklog Time Spent: 10m 
      Work Description: franz1981 edited a comment on pull request #3392:
URL: https://github.com/apache/activemq-artemis/pull/3392#issuecomment-751294656


   That's correct and we were doing already that for clients (and not only) 
IIRC: check 
https://github.com/apache/activemq-artemis/blob/52263663c48082227916cc3477f8892d9f10134b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java#L269
   
   But replication wasn't doing it AFAIK.
   It won't help if the replicated packets are big ie big journal records, but 
ack/rollbacks and other yep because there are very small and frequent.
   The solution I have written here save using a background thread to perform 
the flush using 
https://github.com/apache/activemq-artemis/blob/52263663c48082227916cc3477f8892d9f10134b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java#L269
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 528462)
    Time Spent: 1h 50m  (was: 1h 40m)

> ReplicationManager can batch sent replicated packets
> ----------------------------------------------------
>
>                 Key: ARTEMIS-3045
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3045
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to