[
https://issues.apache.org/jira/browse/ARTEMIS-3049?focusedWorklogId=530759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530759
]
ASF GitHub Bot logged work on ARTEMIS-3049:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 16:47
Start Date: 04/Jan/21 16:47
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #3393:
URL: https://github.com/apache/activemq-artemis/pull/3393#issuecomment-754085723
I've chosen to remove the caching of the last accessed buffer because
multiple consumers would scale negatively due to this and instead, let a
reloaded live cache to benefit from O(1) accesses instead, while getting a more
compacted data representation instead.
The PR is providing a JMH bench to track perf regression on lookup scaling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530759)
Time Spent: 1h 20m (was: 1h 10m)
> Reduce live page lookup cost
> ----------------------------
>
> Key: ARTEMIS-3049
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3049
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.16.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> LivePageCacheImpl::getMessage is performing a linked-list-like lookup that
> can be rather slow if compared to a O(1) lookup on ArrayList-like data
> structure.
> it's possible to speed it up by:
> # using a last accessed buffer cache on the append only chunked list used on
> LivePageCacheImpl, to speedup the most recent (& nearest) accesses
> # using an array with the fresh reloaded paged messages, in case of cache
> reload
> https://github.com/apache/activemq-artemis/pull/2494#issuecomment-455086939
> clearly show the issue with the current implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
