[
https://issues.apache.org/jira/browse/ARTEMIS-3021?focusedWorklogId=531996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531996
]
ASF GitHub Bot logged work on ARTEMIS-3021:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 17:21
Start Date: 06/Jan/21 17:21
Worklog Time Spent: 10m
Work Description: franz1981 edited a comment on pull request #3370:
URL: https://github.com/apache/activemq-artemis/pull/3370#issuecomment-740451251
@gemmellr it seems that AMQP isn't affected by this because a pooled Netty
(heap) buffer is used to encode stuff and then copy an exact sized byte[] where
needed but I see another issue and is the pooled Netty heap buffer.
That stealthy makes the broker memory footprint on heap much larger because
Netty would create large byte[] arenas. I suggest to not use pooled heap buffer
or it can stealthy cause OOM as well.
This means either:
- use off heap pooled Netty buffers to temporarily encode things
- use unpooled heap smartly sizes ones to save both the additional copy and
pooling as a whole
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 531996)
Time Spent: 1h 20m (was: 1h 10m)
> OOM due to wrong CORE message memory estimation
> -----------------------------------------------
>
> Key: ARTEMIS-3021
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3021
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Durable CORE messages can get their internal buffer enlarged by
> encodeHeadersAndProperties while being persisted on the journal, but the
> address size memory estimation using the estimated memory of a message is
> performed before that, making it less precise.
> This bad timing estimation, together with Netty ByteBuf auto-sizing mechanism
> can cause the broker to underestimate the message footprint, causing it to go
> OOM.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
