[ 
https://issues.apache.org/jira/browse/ARTEMIS-3061?focusedWorklogId=534349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534349
 ]

ASF GitHub Bot logged work on ARTEMIS-3061:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jan/21 17:05
            Start Date: 11/Jan/21 17:05
    Worklog Time Spent: 10m 
      Work Description: franz1981 commented on pull request #3404:
URL: https://github.com/apache/activemq-artemis/pull/3404#issuecomment-758090224


   @gemmellr 
   Just a qq about this:
   
   ```java
            if (value instanceof UnsignedInteger ||
               value instanceof UnsignedByte ||
               value instanceof UnsignedLong ||
               value instanceof UnsignedShort) {
               return ((Number) value).longValue();
            }
   ```
   I've improved things a bit on this PR, but still...is it necessary?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 534349)
    Time Spent: 20m  (was: 10m)

> AMQPMessage::getDuplicateProperty can save key comparisons and class checks
> ---------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3061
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3061
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: AMQP
>    Affects Versions: 2.16.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to