[
https://issues.apache.org/jira/browse/AMQNET-572?focusedWorklogId=538785&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538785
]
ASF GitHub Bot logged work on AMQNET-572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/21 00:58
Start Date: 21/Jan/21 00:58
Worklog Time Spent: 10m
Work Description: brudo commented on a change in pull request #3:
URL:
https://github.com/apache/activemq-nms-openwire/pull/3#discussion_r561444751
##########
File path: src/Transport/Failover/FailoverTransport.cs
##########
@@ -1,1689 +1,1701 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
I see what you mean... not sure why that happened on this one and not
the other files... I just pulled from upstream master and resolved the conflict
using the conflict editor - did not even require any hand editing. (I think it
would have been cleaner with a rebase - but I don't think I can do that in an
existing public branch.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538785)
Time Spent: 2h 50m (was: 2h 40m)
> Failover crashes when AMQ Server enforces TLS 1.2
> -------------------------------------------------
>
> Key: AMQNET-572
> URL: https://issues.apache.org/jira/browse/AMQNET-572
> Project: ActiveMQ .Net
> Issue Type: Bug
> Reporter: Dan Taflin
> Priority: Critical
> Attachments: Archivos-1.zip, failoverSslContext.patch
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> When using the FailoverTransport with underlying SslTransports, and
> specifying Tls12 as the SslProtocol, the initial connection to the ActiveMQ
> server succeeds in establishing a TLS v1.2 session. But upon failover, when
> it tries to reconnect, the Tls12 specification is lost and the NMS client
> reverts to the default, which appears to be TLS 1.0.
> The consequence is that it is impossible to enforce TLS 1.2 on the server,
> because although the initial connection would succeed, subsequent ones crash
> the client.
> Here's a sample failover transport URL:
> {{failover:(ssl://server1.example.com:61616?transport.sslProtocol=Tls12,ssl://server2.example.com:61616?transport.sslProtocol=Tls12)}}
> I've traced the issue to the FailoverTransport.DoConnect() method, which,
> when obtaining the ConnectList in order to obtain a url to connect to,
> obtains a url without a querystring. So in the above example,
> transport.sslProtocol=Tls12 is gone. The source of this truncated url is the
> ConnectionControl command marshalled from the server.
> The solution would seem to be to create an SslContext class to keep track of
> the sslProtocol, similar to how the java version works. I have built a
> working prototype for us to use locally and would be willing to make it
> available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
