[
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=542222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542222
]
ASF GitHub Bot logged work on AMQNET-637:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 14:50
Start Date: 26/Jan/21 14:50
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#discussion_r564569796
##########
File path: test/Apache-NMS-AMQP-Test/TestAmqp/TestAmqpPeer.cs
##########
@@ -605,7 +606,49 @@ public void ExpectDurableSubscriberAttach(string
topicName, string subscriptionN
ExpectReceiverAttach(linkNameMatcher: linkNameMatcher,
sourceMatcher: sourceMatcher, targetMatcher: targetMatcher, settled: false,
errorType: null, errorMessage: null);
}
+
+ public void ExpectSharedDurableSubscriberAttach(string topicName,
string subscriptionName)
+ {
+ Action<string> linkNameMatcher = linkName =>
Assert.AreEqual(subscriptionName, linkName);
+
+ Action<object> sourceMatcher = o =>
+ {
+ Assert.IsInstanceOf<Source>(o);
+ var source = (Source) o;
+ Assert.AreEqual(topicName, source.Address);
+ Assert.IsFalse(source.Dynamic);
+ Assert.AreEqual(TerminusDurability.UNSETTLED_STATE,
(TerminusDurability) source.Durable);
+ Assert.AreEqual(TerminusExpiryPolicy.NEVER,
source.ExpiryPolicy);
+ CollectionAssert.Contains(source.Capabilities,
SymbolUtil.ATTACH_CAPABILITIES_TOPIC);
+ CollectionAssert.Contains(source.Capabilities,
SymbolUtil.SHARED);
+ };
+ Action<Target> targetMatcher = Assert.IsNotNull;
+
+ ExpectReceiverAttach(linkNameMatcher: linkNameMatcher,
sourceMatcher: sourceMatcher, targetMatcher: targetMatcher, settled: false,
errorType: null, errorMessage: null);
+ }
+
+ public void ExpectSharedSubscriberAttach(string topicName, string
subscriptionName)
+ {
+ Action<string> linkNameMatcher = linkName =>
Assert.AreEqual(subscriptionName+"|volatile1", linkName);
+
+ Action<object> sourceMatcher = o =>
+ {
+ Assert.IsInstanceOf<Source>(o);
+ var source = (Source) o;
+ Assert.AreEqual(topicName, source.Address);
+ Assert.IsFalse(source.Dynamic);
+ // Assert.AreEqual(TerminusDurability.UNSETTLED_STATE,
(TerminusDurability) source.Durable);
Review comment:
@lukeabsent remove commented code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 542222)
Time Spent: 9h 50m (was: 9h 40m)
> NMS 2.0
> -------
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: NMS
> Affects Versions: 1.8.0
> Reporter: Michael Andre Pearce
> Priority: Major
> Fix For: API-2.0.0
>
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the
> latest JMS 2.0 api
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
