[
https://issues.apache.org/jira/browse/ARTEMIS-3080?focusedWorklogId=546551&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-546551
]
ASF GitHub Bot logged work on ARTEMIS-3080:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 01:16
Start Date: 03/Feb/21 01:16
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3421:
URL: https://github.com/apache/activemq-artemis/pull/3421#discussion_r568474409
##########
File path: artemis-jakarta-client/pom.xml
##########
@@ -0,0 +1,64 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-jakarta-client</artifactId>
+ <packaging>jar</packaging>
+ <name>ActiveMQ Artemis JakartaEE Messaging Client</name>
+
+ <properties>
+ <activemq.basedir>${project.basedir}/..</activemq.basedir>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
Review comment:
I'd say it is often expected a pom will provide the needed classpath,
and would likely be in this case given historic usage. That is to say I expect
few people declaring a dependency on artemis-jms-client are surprised it yields
one, and guess a good proportion who might later try artemis-jakarta-client
would be surprised it didn't similarly. I'm not sure how a bom would help here,
unless the thought is someone could manually copy the needed dep definitions
from its contents? An 'all' jar could certainly be an option (though I don't
like those personally).
Perhaps its fine as a first step, but yes some doc (e.g at least a README in
the module) on how to use it would seem needed, I think people would struggle
to use it as-is otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 546551)
Time Spent: 3h (was: 2h 50m)
> Provide JakartaEE 9 artefacts
> -----------------------------
>
> Key: ARTEMIS-3080
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3080
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.16.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Currently Apache Artemis will provide JMS 2.0 compatible client, server and
> resource adapter. We should also provide JMS 3.0 aka JakartaEE 9 artefacts to
> be consumed and used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
