[
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=550808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550808
]
ASF GitHub Bot logged work on AMQNET-637:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/21 17:14
Start Date: 10/Feb/21 17:14
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #62:
URL: https://github.com/apache/activemq-nms-amqp/pull/62#discussion_r573878528
##########
File path: test/Apache-NMS-AMQP-Interop-Test/NmsMessageConsumerTest.cs
##########
@@ -211,112 +213,120 @@ IMessageConsumer GetConsumer(string subscriptionName,
String clientId)
receivedMessages.Add(2);
msg.Acknowledge();
};
-
+
// Now send some messages
- using ISession sessionProducer =
Connection.CreateSession(AcknowledgementMode.AutoAcknowledge);
- ITopic topicProducer = sessionProducer.GetTopic(TestName);
- using IMessageProducer producer =
sessionProducer.CreateProducer(topicProducer);
- for (int t = 0; t < 10; t++)
+ using (ISession sessionProducer =
Connection.CreateSession(AcknowledgementMode.AutoAcknowledge))
{
- ITextMessage producerMessage =
sessionProducer.CreateTextMessage("text" + t);
- producer.Send(producerMessage, MsgDeliveryMode.Persistent,
MsgPriority.Normal, TimeSpan.Zero);
+ ITopic topicProducer = sessionProducer.GetTopic(TestName);
+ using (IMessageProducer producer =
sessionProducer.CreateProducer(topicProducer))
+ {
+ for (int t = 0; t < 10; t++)
+ {
+ ITextMessage producerMessage =
sessionProducer.CreateTextMessage("text" + t);
+ producer.Send(producerMessage,
MsgDeliveryMode.Persistent, MsgPriority.Normal, TimeSpan.Zero);
+ }
+ }
}
// Give it some time to process
Thread.Sleep(TimeSpan.FromSeconds(2));
-
+
// Assert message was routed to multiple consumers
Assert.AreEqual(2, receivedMessages.Distinct().Count());
Assert.AreEqual(10, receivedMessages.Count);
}
-
+
[Test, Timeout(60_000)]
public void TestSharedDurableSubscription()
{
- (IMessageConsumer,ISession,IConnection) GetConsumer(string
subscriptionName, String clientId)
+ (IMessageConsumer, ISession, IConnection) GetConsumer(string
subName, String clientId)
{
var connection = CreateAmqpConnection(clientId);
ISession session =
connection.CreateSession(AcknowledgementMode.AutoAcknowledge);
var topic = session.GetTopic(TestName);
- var messageConsumer =
session.CreateSharedDurableConsumer(topic, subscriptionName);
+ var messageConsumer =
session.CreateSharedDurableConsumer(topic, subName);
Review comment:
why was this needed? def -1 on moving from full clear name to some
abbreviation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550808)
Time Spent: 12h 10m (was: 12h)
> NMS 2.0
> -------
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: NMS
> Affects Versions: 1.8.0
> Reporter: Michael Andre Pearce
> Priority: Major
> Fix For: API-2.0.0
>
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the
> latest JMS 2.0 api
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
