[
https://issues.apache.org/jira/browse/ARTEMIS-3113?focusedWorklogId=550861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550861
]
ASF GitHub Bot logged work on ARTEMIS-3113:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/21 19:15
Start Date: 10/Feb/21 19:15
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3448:
URL: https://github.com/apache/activemq-artemis/pull/3448#discussion_r574004669
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AMQPMessageSupport.java
##########
@@ -54,15 +42,18 @@
import org.apache.qpid.proton.amqp.Symbol;
import org.apache.qpid.proton.amqp.messaging.Data;
import org.apache.qpid.proton.message.Message;
-import org.jboss.logging.Logger;
/**
* Support class containing constant values and static methods that are used
to map to / from
* AMQP Message types being sent or received.
*/
public final class AMQPMessageSupport {
- private static final Logger logger =
Logger.getLogger(AMQPMessageSupport.class);
+ // These are duplicates from ActiveMQDestination on the jms module.
Review comment:
-1 please dont duplicate stuff. If needed place into some common place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550861)
Time Spent: 1h 50m (was: 1h 40m)
> Artemis AMQP shouldn't depend on JMS
> ------------------------------------
>
> Key: ARTEMIS-3113
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3113
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.16.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The converters between core messages and amqp messages depend on JMS. Since
> this is just for convenience we should remove this dependecy on an API that
> is being replaced.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
