[
https://issues.apache.org/jira/browse/ARTEMIS-3113?focusedWorklogId=550952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550952
]
ASF GitHub Bot logged work on ARTEMIS-3113:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/21 20:44
Start Date: 10/Feb/21 20:44
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3448:
URL: https://github.com/apache/activemq-artemis/pull/3448#discussion_r574062357
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
##########
@@ -425,7 +419,7 @@ private static Section convertBody(ServerJMSMessage
message, Map<Symbol, Object>
break;
}
} else if (message instanceof ServerJMSTextMessage) {
- String text = (((TextMessage) message).getText());
+ String text = (((ServerJMSTextMessage) message).getText());
Review comment:
I would then duplicate the whole JMS API internally for the conversion.
That is a BytesMessage, a TextMessage ...etc... etc... When all we need is
the Concrete Type. This is not supposed to used by any users other than the
conversion.
Notice this ServerJMSTextMessage is a class that only lives as part of the
AMQP implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550952)
Time Spent: 6h 40m (was: 6.5h)
> Artemis AMQP shouldn't depend on JMS
> ------------------------------------
>
> Key: ARTEMIS-3113
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3113
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.16.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> The converters between core messages and amqp messages depend on JMS. Since
> this is just for convenience we should remove this dependecy on an API that
> is being replaced.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
