[
https://issues.apache.org/jira/browse/AMQNET-572?focusedWorklogId=551250&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-551250
]
ASF GitHub Bot logged work on AMQNET-572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/21 10:45
Start Date: 11/Feb/21 10:45
Worklog Time Spent: 10m
Work Description: brudo commented on pull request #3:
URL:
https://github.com/apache/activemq-nms-openwire/pull/3#issuecomment-777355618
@michaelpearce-gain, that was mainly responding to comments from @Havret and
@dtaflin. Perhaps also adding my own review; perhaps trying to size up the
remaining problems.
I haven't done any more actual work on this. I did prepare a branch in my
fork with the same changes, rebased. The actual source code is identical, and
would be subject to the same comments expressed here.
Meanwhile, in the branch for this PR, should I revert the merge commit that
led to the bad diff in FailoverTransport.cs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 551250)
Time Spent: 4h 40m (was: 4.5h)
> Failover crashes when AMQ Server enforces TLS 1.2
> -------------------------------------------------
>
> Key: AMQNET-572
> URL: https://issues.apache.org/jira/browse/AMQNET-572
> Project: ActiveMQ .Net
> Issue Type: Bug
> Reporter: Dan Taflin
> Priority: Critical
> Attachments: Archivos-1.zip, failoverSslContext.patch
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> When using the FailoverTransport with underlying SslTransports, and
> specifying Tls12 as the SslProtocol, the initial connection to the ActiveMQ
> server succeeds in establishing a TLS v1.2 session. But upon failover, when
> it tries to reconnect, the Tls12 specification is lost and the NMS client
> reverts to the default, which appears to be TLS 1.0.
> The consequence is that it is impossible to enforce TLS 1.2 on the server,
> because although the initial connection would succeed, subsequent ones crash
> the client.
> Here's a sample failover transport URL:
> {{failover:(ssl://server1.example.com:61616?transport.sslProtocol=Tls12,ssl://server2.example.com:61616?transport.sslProtocol=Tls12)}}
> I've traced the issue to the FailoverTransport.DoConnect() method, which,
> when obtaining the ConnectList in order to obtain a url to connect to,
> obtains a url without a querystring. So in the above example,
> transport.sslProtocol=Tls12 is gone. The source of this truncated url is the
> ConnectionControl command marshalled from the server.
> The solution would seem to be to create an SslContext class to keep track of
> the sslProtocol, similar to how the java version works. I have built a
> working prototype for us to use locally and would be willing to make it
> available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
