[
https://issues.apache.org/jira/browse/ARTEMIS-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram resolved ARTEMIS-2931.
-------------------------------------
Fix Version/s: 2.18.0
Resolution: Fixed
> Potential null pointer access at several places
> ------------------------------------------------
>
> Key: ARTEMIS-2931
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2931
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Petr Kuzel
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Open the artemis-server project in Eclipse. Static analysis reports numerous
> Potential null pointer access. Looking at an example, the static analyzer is
> correct.
> ReplicationEndpoint:
> {code:java}
> public void setChannel(final Channel channel) {
> this.channel = channel;
> if (channel == null) {
> supportResponseBatching = false;
> } else {
> try {
> final CoreRemotingConnection connection = channel.getConnection();
> if (connection != null) {
> this.supportResponseBatching =
> connection.getTransportConnection() instanceof NettyConnection;
> } else {
> this.supportResponseBatching = false;
> }
> } catch (Throwable t) {
> logger.warn("Error while checking the channel connection", t);
> this.supportResponseBatching = false;
> }
> } if (this.channel != null && outgoingInterceptors != null) {
> if (channel.getConnection() instanceof RemotingConnectionImpl) { //
> NPE risk
> {code}
> line 392 the channel can be null.
> line 409 for unknown reason assumes the channel is never null.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
