[
https://issues.apache.org/jira/browse/ARTEMIS-3133?focusedWorklogId=556332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556332
]
ASF GitHub Bot logged work on ARTEMIS-3133:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/21 13:24
Start Date: 23/Feb/21 13:24
Worklog Time Spent: 10m
Work Description: franz1981 commented on a change in pull request #3462:
URL: https://github.com/apache/activemq-artemis/pull/3462#discussion_r581029960
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
##########
@@ -921,7 +979,11 @@ private void doConfirmAndResponse(final Packet
confirmPacket,
}
if (response != null) {
- channel.send(response);
+ try {
+ channel.send(response);
Review comment:
it's completely sync and won't retain the `Packet` unless the conf
window size is != -1, where it can use a `resendCache` to store it.
In this case the caching won't happen, see
https://github.com/apache/activemq-artemis/pull/3462/files#diff-c58d25d4978ebff7d03f1e5858b8b3344b01b3f2376e5ff194483d85c7b36a09R200-R208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 556332)
Time Spent: 2h 10m (was: 2h)
> Reduce memory usage for Null an Ping packets
> --------------------------------------------
>
> Key: ARTEMIS-3133
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3133
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently NullResponseMessage and Ping report a wrong expected size (==
> 1500): it means that the allocated Netty buffers will be much bigger then
> necessary eg null is 13 bytes, while null v2 is 21.
>
> In addition, NullReponseMessage could be cached if the transport channel
> won't use any resend cache, greatly reducing the memory used under load.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
