[
https://issues.apache.org/jira/browse/ARTEMIS-3135?focusedWorklogId=556414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556414
]
ASF GitHub Bot logged work on ARTEMIS-3135:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/21 15:47
Start Date: 23/Feb/21 15:47
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3464:
URL: https://github.com/apache/activemq-artemis/pull/3464#discussion_r581151758
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -3733,16 +3733,6 @@ private boolean deliver(final MessageReference ref) {
}
}
- private static void accountForChangeInMemoryEstimate(final MessageReference
ref, final int existingMemoryEstimate) {
- final int delta = ref.getMessageMemoryEstimate() -
existingMemoryEstimate;
- if (delta > 0) {
Review comment:
what if the delta was lower?
shouldn't you set messageMemoryEstimate, in case there are further changes
on the message...
(just to keep it ready for future usages, say a transformation)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 556414)
Time Spent: 40m (was: 0.5h)
> AMQ222214: Destination q has an inconsistent and negative address size=-6
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-3135
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3135
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.17.0
> Reporter: Erwin Dondorp
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.18.0
>
> Attachments: broker.xml
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The following messages appear after sending a message and then manual
> deleting it using the GUI:
> {{AMQ222214: Destination q has an inconsistent and negative address size=-6}}
> and
> {{AMQ222215: Global Address Size has negative and inconsistent value as -6}}
> The file {{broker.xml}} is almost pristine, except for the addition of
> anycast destination {{q}}.
> using simply {{<address name="q"><anycast><queue
> name="q"/></anycast></address>}}
> The message that was sent is a simple text message sent using the AMQP
> protocol to this queue.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
