[
https://issues.apache.org/jira/browse/ARTEMIS-3106?focusedWorklogId=557984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557984
]
ASF GitHub Bot logged work on ARTEMIS-3106:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/21 15:30
Start Date: 25/Feb/21 15:30
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #3470:
URL: https://github.com/apache/activemq-artemis/pull/3470#issuecomment-785987366
> I have spitted this PR in 5 commits:
>
> 1. Code developed completely by my own with the standard headers added
> 2. Code I have taken from https://github.com/ogrebgr/scram-sasl modified
it (e.g. additional exception checks, removed unnecessary parts), that code is
originally licensed APL 2.0 and I have keep the original headers there
> 3. I reformated my code and the 3rd-party code according to the Artemis
checkstyle rules
> 4. An example that uses both codes, inspired by the artemis examples
> 5. some refactoring that was necessary for handling users+roles
>
> I hope this makes clear whats "my" work and what might be "derived" or
"prio" work, as everything is/was Apache licensed I'm not sure if/how notice
files need to be addressed here.
It's probably ok... but I think you should state original authorship on the
classes where you're deriving it.
for the specific derivation I think you should keep it a separate commit for
what's worth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 557984)
Time Spent: 2h 10m (was: 2h)
> Support for SASL-SCRAM
> ----------------------
>
> Key: ARTEMIS-3106
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3106
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
> Reporter: Christoph Läubrich
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> With the enhancements in ARTEMIS-33 / [PR
> 3432|https://github.com/apache/activemq-artemis/pull/3432] it would be now
> possible to plug-in new SASL mechanism.
> One popular one is
> [SASL-SCRAM|https://en.wikipedia.org/wiki/Salted_Challenge_Response_Authentication_Mechanism]
> because it allows channelbinding together with secure storage of
> user-credential.
> I have created an [implementation of this for Artemis
> AMQP|https://github.com/laeubi/scram-sasl/tree/artemis/artemis] based on the
> [SCRAM SASL authentication for Java|https://github.com/ogrebgr/scram-sasl]
> code with some enhancements/cleanups to the original.
> As the source is already Apache licensed I'd like to propose to include this
> in the Artemis code-base. This would greatly enhance the interoperability
> with other implementations e.g. Apache QPID.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
