[
https://issues.apache.org/jira/browse/ARTEMIS-3137?focusedWorklogId=557995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557995
]
ASF GitHub Bot logged work on ARTEMIS-3137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/21 15:54
Start Date: 25/Feb/21 15:54
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3466:
URL: https://github.com/apache/activemq-artemis/pull/3466#discussion_r582947088
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
##########
@@ -1271,4 +1271,22 @@ public Object getOwner() {
public void setOwner(Object object) {
this.owner = object;
}
+
+ @Override
+ public String getStringBody() {
+ String body = null;
+
+ if (type == TEXT_TYPE) {
+ try {
+ SimpleString simpleBody =
getBodyBuffer().readNullableSimpleString();
Review comment:
Just found the method you have to use...
use getDataBuffer() instead...
This method will return a getReadOnlyBodyBuffer() for StandardMessages
or it will read the whole LargeMessage into Memory before parsing it.
Which is actually a decision we have to make.. if LargeMessages should be
part of the filter here.
if you do, we should at least keep a documentation with a warning about
large messages and the feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 557995)
Time Spent: 2h 40m (was: 2.5h)
> Support XPath filters
> ---------------------
>
> Key: ARTEMIS-3137
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3137
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
