[
https://issues.apache.org/jira/browse/ARTEMIS-3180?focusedWorklogId=566697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566697
]
ASF GitHub Bot logged work on ARTEMIS-3180:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/21 03:09
Start Date: 16/Mar/21 03:09
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3492:
URL: https://github.com/apache/activemq-artemis/pull/3492#discussion_r594827965
##########
File path:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/AddressMapUnitTest.java
##########
@@ -638,7 +638,7 @@ public void testHashA() throws Exception {
assertFalse(aABCA.matches(aHashA));
assertFalse(aHashA.matches(aABCA));
- assertEquals(0, countMatchingWildcards(abcaS));
+ assertEquals(1, countMatchingWildcards(abcaS));
Review comment:
My issue is that would be a change of behaviour, that some users may
have got used to and built systems around such quirks. As such just changing
that may break many users.
If theres a change in behaviour it needs to be behind a toggle and then by
default kept as original. And original behaviour tests kept as is to ensure
that.
This is the same as when we aligned queue naming for amqp, so that it used
the same rules as core and openwire so there wasnt a conflict and you could
then have openwire core and amqp consumers share the same shares subs (queues).
Whilst it would have been nice to default on the better new behaviour, to avoid
least astonishment for existing users it went behind a toggle and defaulted to
the original behaviour.
Only at the next major release aka 3.0.0 would we then be able to change
that default behaviour (break change) with the major version change. Theres a
few things like the one i mentioned thats waiting to change those defaults at
the next major.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 566697)
Time Spent: 2h 40m (was: 2.5h)
> Consumers with wildcards addresses broken
> -----------------------------------------
>
> Key: ARTEMIS-3180
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3180
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
> Affects Versions: 2.17.0
> Environment: Artemis 2.17.0
> openjdk version "1.8.0_275"
> OpenJDK Runtime Environment (build 1.8.0_275-b01)
> OpenJDK 64-Bit Server VM (build 25.275-b01, mixed mode)
> Reporter: Sebastian T
> Assignee: Gary Tully
> Priority: Blocker
> Attachments: artemis-3180.zip
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> While upgrading from Artemis 2.16.0 to 2.17.0 several of our test cases
> started failing.
> We are using AMQP and QPid JMS to communicate to Artemis.
> The issue seems to be related to subscriptions with wildcards.
> Sending a message to an address "topics.aaa.bbb.ccc" with a consumer
> subscribed to "topics.#.aaa.#" and one with "topics.#.bbb.#" only the
> consumer subscribed to "topics.#.aaa.#" receives the message.
> I am attaching a test case illustrating the issue.
> Running "mvn test" executes it with Artemis 2.17.0 and will fail. "mvn test
> -Dartemis.version=2.16.0" executes the test with Artemis 2.16.0 and will
> succeed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
