[
https://issues.apache.org/jira/browse/ARTEMIS-3106?focusedWorklogId=571380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-571380
]
ASF GitHub Bot logged work on ARTEMIS-3106:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/21 18:19
Start Date: 24/Mar/21 18:19
Worklog Time Spent: 10m
Work Description: laeubi edited a comment on pull request #3470:
URL: https://github.com/apache/activemq-artemis/pull/3470#issuecomment-806051272
> My earlier feedback about lack of unit tests remains.
is there anything specifically you are missing here? The integration test
should already cover most of the use-cases I think. The
broker-interconnect-testing even verifies it on a very low-level without any
additional configuration involved.
> I really would consider just omitting the SCRAM-SHA-1 support at this
point personally, I dont see great value in adding it at this
But whats the value in removing it? It does not simplify the code, it is not
enabled by default (so peopel can choose if they want to enable it or not) and
it does not remove complexity as it is just another set of algorithms. On the
other hand, adding it "later" or let people "just plug in their own support for
it" seems way much more effort on the long run. For example the client-side is
currently not pluggable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 571380)
Time Spent: 14h 40m (was: 14.5h)
> Support for SASL-SCRAM
> ----------------------
>
> Key: ARTEMIS-3106
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3106
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
> Reporter: Christoph Läubrich
> Priority: Major
> Time Spent: 14h 40m
> Remaining Estimate: 0h
>
> With the enhancements in ARTEMIS-33 / [PR
> 3432|https://github.com/apache/activemq-artemis/pull/3432] it would be now
> possible to plug-in new SASL mechanism.
> One popular one is
> [SASL-SCRAM|https://en.wikipedia.org/wiki/Salted_Challenge_Response_Authentication_Mechanism]
> because it allows channelbinding together with secure storage of
> user-credential.
> I have created an [implementation of this for Artemis
> AMQP|https://github.com/laeubi/scram-sasl/tree/artemis/artemis] based on the
> [SCRAM SASL authentication for Java|https://github.com/ogrebgr/scram-sasl]
> code with some enhancements/cleanups to the original.
> As the source is already Apache licensed I'd like to propose to include this
> in the Artemis code-base. This would greatly enhance the interoperability
> with other implementations e.g. Apache QPID.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
