[
https://issues.apache.org/jira/browse/ARTEMIS-3219?focusedWorklogId=576200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576200
]
ASF GitHub Bot logged work on ARTEMIS-3219:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/21 17:31
Start Date: 02/Apr/21 17:31
Worklog Time Spent: 10m
Work Description: franz1981 edited a comment on pull request #3526:
URL: https://github.com/apache/activemq-artemis/pull/3526#issuecomment-812610771
This is both improving performance of FQQN routing by reducing the amount of
map lookups to compute the next binding search and it's improving normal
routing by removing from the hot path less common/slow path methods eg
duplicate cache lookups.
@clebertsuconic The 3 important changes here:
- no longer 2 caches: just a single cache to both compute the next binding
position and add/remove bindings
- next binding position logic won't throws array out of bounds exception,
because always use stable snapshots
- no longer `Integer` and `SimpleString` leaks in the binding position cache
while performing concurrent bindings addition/removal
I need to run an end 2 end test with FQQN before merging this + running the
full CI, because it contains a big number of changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 576200)
Time Spent: 50m (was: 40m)
> Improve FQQN message routing
> ----------------------------
>
> Key: ARTEMIS-3219
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3219
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)