[
https://issues.apache.org/jira/browse/ARTEMIS-3241?focusedWorklogId=584124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584124
]
ASF GitHub Bot logged work on ARTEMIS-3241:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/21 07:55
Start Date: 16/Apr/21 07:55
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3546:
URL: https://github.com/apache/activemq-artemis/pull/3546#discussion_r614637143
##########
File path:
artemis-distribution/src/main/resources/licenses/bin/licenses/LICENSE-angular-resizable.txt
##########
@@ -0,0 +1,7 @@
+Permission to use, copy, modify, distribute, and sell this software and its
+documentation for any purpose is hereby granted without fee, provided that
+the above copyright notice appear in all copies and that both that
+copyright notice and this permission notice appear in supporting
+documentation. No representations are made about the suitability of this
+software for any purpose. It is provided "as is" without express or
+implied warranty.
Review comment:
No, we definitely shouldnt do that, as it does actually have a licence,
an MIT variant, and it needs to or we probably cant use it. Just put it back
the way it was, as silly as that is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 584124)
Time Spent: 1h 20m (was: 1h 10m)
> binary archive LICENSE file contains improper (and possibly stale) entries
> for management console deps
> ------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3241
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3241
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Web Console
> Affects Versions: 2.17.0
> Reporter: Robbie Gemmell
> Priority: Blocker
> Fix For: 2.18.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The licence file shipped with the binary distribution contains a lot of
> improper, and possibly stale (see later), entries relating to the management
> console deps:
> https://github.com/apache/activemq-artemis/blob/2.17.0/artemis-distribution/src/main/resources/licenses/bin/LICENSE#L256-L435
> These entries added mostly link to a file in an external repository, on its
> master branch. This applicable licences should actually be in the
> distribution itself (either directly in LICENCE, or in another file
> referenced from it), links arent sufficient because their contents can change
> over time (e.g licence and/or version changes) or even go away entirely or
> just be broken (e.g branch changes) and so may not actually reflect the
> needed detail or the state that existed when the dependency was used and the
> LICENCE file entry added.
> Further, these entries could also be somewhat stale now, because they were
> added in ARTEMIS-1270 back in 2017 but the console has been overhauled
> recently in ARTEMIS-2838. In addition to being updated to actually ship the
> licence, the entries should be verified as still applying, and that there
> aren't any new ones needed from the console update.
> (Noticed during discussion of LICENSE changes on
> https://github.com/apache/activemq-artemis/pull/3527 / ARTEMIS-3221)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
