[
https://issues.apache.org/jira/browse/ARTEMIS-3271?focusedWorklogId=590416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590416
]
ASF GitHub Bot logged work on ARTEMIS-3271:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/21 13:59
Start Date: 28/Apr/21 13:59
Worklog Time Spent: 10m
Work Description: gtully commented on pull request #3557:
URL: https://github.com/apache/activemq-artemis/pull/3557#issuecomment-828479163
looks good. the test captures the failure nicely. I guess the sampling is
not unlike the current behaviour where multiple threads can modify the state.
At least now there won't be any false positives.
also good that we are down to a single value to update for a single thread.
nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 590416)
Time Spent: 20m (was: 10m)
> Avoid Multi Thread measurement on Critical Analyzer
> ---------------------------------------------------
>
> Key: ARTEMIS-3271
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3271
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.17.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Critical Analyzer could be called from multiple Threads.
>
> As a result, I am afraid there could be a situation that left time was
> updated at a wrong pace.. leaving to inconsistencies.
>
>
> I'm improving it to only consider a single thread from all the calls. Any
> calls from multi-threading should be ignored... All we need is to capture one
> thread hanging and detect a dead lock.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
