[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597092
]
ASF GitHub Bot logged work on ARTEMIS-3297:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/21 04:31
Start Date: 15/May/21 04:31
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632893752
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -768,6 +772,45 @@ public void parseMainConfig(final Element e, final
Configuration config) throws
}
}
+
+ private void parseJournalRetention(final Element e, final Configuration
config) {
+ NodeList retention = e.getElementsByTagName("journal-retention");
+
+ if (retention.getLength() != 0) {
+ Element node = (Element) retention.item(0);
+
+ String directory = getAttributeValue(node, "directory");
+ long storageLimit = ByteUtil.convertTextBytes(getAttributeValue(node,
"storage-limit").trim());
+ int period = getAttributeInteger(node, "period", 0,
Validators.GT_ZERO);
+ String unitStr = getAttributeValue(node, "unit");
+
+ TimeUnit unit;
+
+ switch (unitStr) {
+ case "DAYS":
+ unit = TimeUnit.DAYS;
+ break;
+ case "HOURS":
+ unit = TimeUnit.HOURS;
+ break;
+ case "MINUTES":
+ unit = TimeUnit.MINUTES;
+ break;
+ case "SECONDS":
+ unit = TimeUnit.SECONDS;
+ break;
+ default:
+ unit = TimeUnit.DAYS;
+ }
+
+ config.setJournalRetentionDirectory(directory);
+ config.setJournalRetentionTimeUnit(unit);
Review comment:
I will think about this between tomorrow (Saturday) and Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 597092)
Time Spent: 8.5h (was: 8h 20m)
> Journal Retention Feature
> -------------------------
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.17.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
