[
https://issues.apache.org/jira/browse/ARTEMIS-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347374#comment-17347374
]
Francesco Nigro edited comment on ARTEMIS-3290 at 5/19/21, 8:13 AM:
--------------------------------------------------------------------
[~clebertsuconic] This issue can be turned into a "remove explicit record ID
checks" or just do something similar to what I've proposed on
https://issues.apache.org/jira/browse/ARTEMIS-3290's PR.
I believe there are many simplifications on the Journal impl that could be done
just by checking which method calls are effectively used and how: probably it
would make the need of checking for record ID to simply disappear.
was (Author: nigrofranz):
[~clebertsuconic] This issue can be turned into a "remove explicit record ID
checks" and just do something similar to what I've proposed on
https://issues.apache.org/jira/browse/ARTEMIS-3290's PR.
I believe there are many simplifications on the Journal impl that could be done
just by checking which method calls are effectively used and how: probably it
would make the need of checking for record ID to simply disappear.
> JournalImpl::checkKnownRecordID can save RTT on append executor
> ---------------------------------------------------------------
>
> Key: ARTEMIS-3290
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3290
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
>
> {{JournalImpl::checkKnownRecordID}}'s slow path is performing a sync task on
> journal `appendExecutor` to check for record existence while journal is
> processing some record eg under a burst of append records.
> Considered that {{checkKnownRecordID}} is always called before an async
> append on the same executor, probably worth inlining the
> {{checkKnownRecordID}} slow path into the subsequent append, saving 1 RTT and
> improving append latency under heavy load.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
