[ 
https://issues.apache.org/jira/browse/ARTEMIS-3294?focusedWorklogId=599673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-599673
 ]

ASF GitHub Bot logged work on ARTEMIS-3294:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/May/21 08:17
            Start Date: 20/May/21 08:17
    Worklog Time Spent: 10m 
      Work Description: gtully commented on a change in pull request #3589:
URL: https://github.com/apache/activemq-artemis/pull/3589#discussion_r635878475



##########
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
##########
@@ -579,7 +579,8 @@ public void testTextMessageAttributeLimits() throws 
Exception {
 
       final String twentyBytes = new String(new char[20]).replace("\0", "#");
 
-      ClientMessage clientMessage = createTextMessage(session, twentyBytes, 
true);

Review comment:
       is there any value in the existing test?
   
   I guess it is possible to put anything into a core message, it is up to the 
reader to know that it will be possibly nullable, no? Or was the assumption 
just wrong. It is an error to encode a plain string?
   
   if it is not an error, then maybe we need to include both test variants.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 599673)
    Time Spent: 1h 20m  (was: 1h 10m)

> Error browsing messages with a text body
> ----------------------------------------
>
>                 Key: ARTEMIS-3294
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3294
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Domenico Francesco Bruscino
>            Assignee: Domenico Francesco Bruscino
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The web console returns the following error on browsing messages with a text 
> body:
> {code:java}
> [hawtio-core] Operation browse(int, int, java.lang.String) failed due to: 
> java.lang.IndexOutOfBoundsException : Error reading in simpleString, 
> length=510918757 is greater than readableBytes=27
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to