[ 
https://issues.apache.org/jira/browse/ARTEMIS-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350486#comment-17350486
 ] 

ASF subversion and git services commented on ARTEMIS-3314:
----------------------------------------------------------

Commit ecad4fb6e496f04fc3885e3d445b40a82f2e000a in activemq-artemis's branch 
refs/heads/main from Robbie Gemmell
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=ecad4fb ]

ARTEMIS-3314: fix warning about not triggering inclusion filter


> Fix warnings about not triggering artifact inclusion or including module 
> artifact
> ---------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3314
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3314
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>    Affects Versions: 2.17.0
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 2.18.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When looking into an issue with the assembly after updating the 
> assembly-plugin in ARTEMIS-3296 recently, I noticed the assembly build logs 
> lots of warnings, a couple of which can be trivially removed.
> The first, about not  is logged 27 times:
> {noformat}
> [WARNING] Cannot include project artifact: 
> org.apache.activemq:apache-artemis:pom:2.18.0-SNAPSHOT; it doesn't have an 
> associated file or directory.
> {noformat}
> This is as there are 9 dependencySets used, and 3 assembleis created. Simply 
> configuring it not to try using the module artifact (a pom, which isnt 
> included anyway) will suppress these.
> The second about a dependency not matching the specified include filter in 
> artemis-distribution/src/main/assembly/dep.xml is logged 3 times:
> {noformat}
> [WARNING] The following patterns were never triggered in this artifact 
> inclusion filter:
> o 'com.sun.xml.bind:jaxb-core
> {noformat}
> Checking the latest 2.17.0 release, the jar is not included in the assembly.
> This entry looks to have been introduced in 
> [94c34b7ed9345a4be4948a52ff3a177b270cd0e6 
> |https://github.com/apache/activemq-artemis/commit/94c34b7ed9345a4be4948a52ff3a177b270cd0e6]
>  before 2.6.0, when the jar was indeed included in the assembly, as it was in 
> 2.16.0 before it then disappeared in 2.17.0. Since it was doesnt look to have 
> ever been an explicit dependency mentioned in any code changes, it was 
> presumably a transitive dependency of something included in the assembly and 
> is no longer transitive after e.g a version update and so no longer matches 
> the filter. As such it should be removed to stop the warnings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to