[
https://issues.apache.org/jira/browse/ARTEMIS-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated ARTEMIS-3314:
------------------------------------
Description:
When looking into an issue with the assembly after updating the assembly-plugin
in ARTEMIS-3296 recently, I noticed the assembly build logs close to 50
warnings, making it difficult to see actual issues creep in as one had, and
which could be removed.
The first, about not including the module artifact is logged nearly 30 times:
{noformat}
[WARNING] Cannot include project artifact:
org.apache.activemq:apache-artemis:pom:2.18.0-SNAPSHOT; it doesn't have an
associated file or directory.
{noformat}
Simply configuring things not to try using the module artifact (a pom, which
isnt expected to be included) will suppress these.
The second about a dependency not matching the specified include filter in
artemis-distribution/src/main/assembly/dep.xml is logged a few times:
{noformat}
[WARNING] The following patterns were never triggered in this artifact
inclusion filter:
o 'com.sun.xml.bind:jaxb-core
{noformat}
Checking the latest 2.17.0 release, the jar is not included in the assembly.
This entry looks to have been introduced in
[94c34b7ed9345a4be4948a52ff3a177b270cd0e6
|https://github.com/apache/activemq-artemis/commit/94c34b7ed9345a4be4948a52ff3a177b270cd0e6]
before 2.6.0, when the jar was indeed included in the assembly, as it was in
2.16.0 before it then disappeared in 2.17.0. Since it was doesnt look to have
ever been an explicit dependency mentioned in any code changes, it was
presumably a transitive dependency of something included in the assembly and is
no longer transitive after e.g a version update and so no longer matches the
filter. As such it should be removed to stop the warnings.
There are also many warnings output for use of "/" as a path in the assembly
config, which can be avoided by not doing so:
{noformat}
[WARNING] The assembly descriptor contains a filesystem-root relative
reference, which is not cross platform compatible /
{noformat}
The build also warns while building a directory output in the same execution as
the tar and zip archives, as it tries to attach the dir to the module output
which isnt possible:
{noformat}
[WARNING] Assembly file:
/home/rgemmell/workspace/activemq-artemis/artemis-distribution/target/apache-artemis-2.18.0-SNAPSHOT-bin
is not a regular file (it may be a directory). It cannot be attached to the
project build for installation or deployment.
{noformat}
Adjusting the module to build the archives and dir in separate executions and
not attaching the dir would resolve this.
was:
When looking into an issue with the assembly after updating the assembly-plugin
in ARTEMIS-3296 recently, I noticed the assembly build logs lots of warnings, a
couple of which can be trivially removed.
The first, about not is logged 27 times:
{noformat}
[WARNING] Cannot include project artifact:
org.apache.activemq:apache-artemis:pom:2.18.0-SNAPSHOT; it doesn't have an
associated file or directory.
{noformat}
This is as there are 9 dependencySets used, and 3 assembleis created. Simply
configuring it not to try using the module artifact (a pom, which isnt included
anyway) will suppress these.
The second about a dependency not matching the specified include filter in
artemis-distribution/src/main/assembly/dep.xml is logged 3 times:
{noformat}
[WARNING] The following patterns were never triggered in this artifact
inclusion filter:
o 'com.sun.xml.bind:jaxb-core
{noformat}
Checking the latest 2.17.0 release, the jar is not included in the assembly.
This entry looks to have been introduced in
[94c34b7ed9345a4be4948a52ff3a177b270cd0e6
|https://github.com/apache/activemq-artemis/commit/94c34b7ed9345a4be4948a52ff3a177b270cd0e6]
before 2.6.0, when the jar was indeed included in the assembly, as it was in
2.16.0 before it then disappeared in 2.17.0. Since it was doesnt look to have
ever been an explicit dependency mentioned in any code changes, it was
presumably a transitive dependency of something included in the assembly and is
no longer transitive after e.g a version update and so no longer matches the
filter. As such it should be removed to stop the warnings.
> Fix warnings about not triggering artifact inclusion or including module
> artifact
> ---------------------------------------------------------------------------------
>
> Key: ARTEMIS-3314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3314
> Project: ActiveMQ Artemis
> Issue Type: Task
> Affects Versions: 2.17.0
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When looking into an issue with the assembly after updating the
> assembly-plugin in ARTEMIS-3296 recently, I noticed the assembly build logs
> close to 50 warnings, making it difficult to see actual issues creep in as
> one had, and which could be removed.
> The first, about not including the module artifact is logged nearly 30 times:
> {noformat}
> [WARNING] Cannot include project artifact:
> org.apache.activemq:apache-artemis:pom:2.18.0-SNAPSHOT; it doesn't have an
> associated file or directory.
> {noformat}
> Simply configuring things not to try using the module artifact (a pom, which
> isnt expected to be included) will suppress these.
> The second about a dependency not matching the specified include filter in
> artemis-distribution/src/main/assembly/dep.xml is logged a few times:
> {noformat}
> [WARNING] The following patterns were never triggered in this artifact
> inclusion filter:
> o 'com.sun.xml.bind:jaxb-core
> {noformat}
> Checking the latest 2.17.0 release, the jar is not included in the assembly.
> This entry looks to have been introduced in
> [94c34b7ed9345a4be4948a52ff3a177b270cd0e6
> |https://github.com/apache/activemq-artemis/commit/94c34b7ed9345a4be4948a52ff3a177b270cd0e6]
> before 2.6.0, when the jar was indeed included in the assembly, as it was in
> 2.16.0 before it then disappeared in 2.17.0. Since it was doesnt look to have
> ever been an explicit dependency mentioned in any code changes, it was
> presumably a transitive dependency of something included in the assembly and
> is no longer transitive after e.g a version update and so no longer matches
> the filter. As such it should be removed to stop the warnings.
> There are also many warnings output for use of "/" as a path in the assembly
> config, which can be avoided by not doing so:
> {noformat}
> [WARNING] The assembly descriptor contains a filesystem-root relative
> reference, which is not cross platform compatible /
> {noformat}
> The build also warns while building a directory output in the same execution
> as the tar and zip archives, as it tries to attach the dir to the module
> output which isnt possible:
> {noformat}
> [WARNING] Assembly file:
> /home/rgemmell/workspace/activemq-artemis/artemis-distribution/target/apache-artemis-2.18.0-SNAPSHOT-bin
> is not a regular file (it may be a directory). It cannot be attached to the
> project build for installation or deployment.
> {noformat}
> Adjusting the module to build the archives and dir in separate executions and
> not attaching the dir would resolve this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
