[
https://issues.apache.org/jira/browse/ARTEMIS-3261?focusedWorklogId=607442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607442
]
ASF GitHub Bot logged work on ARTEMIS-3261:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/21 15:32
Start Date: 05/Jun/21 15:32
Worklog Time Spent: 10m
Work Description: franz1981 commented on a change in pull request #3610:
URL: https://github.com/apache/activemq-artemis/pull/3610#discussion_r646003861
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##########
@@ -323,20 +325,26 @@ public JournalImpl setHistoryFolder(File historyFolder,
long maxBytes, long peri
private final ReadWriteLock journalLock = new ReentrantReadWriteLock();
private final ReadWriteLock compactorLock = new ReentrantReadWriteLock();
- HashSet<Integer> replaceableRecords;
+ ByteObjectHashMap<Byte> replaceableRecords;
Review comment:
Given that I don't know if it's an hot path I am already happy with the
PR as it is: this one is just an improvement, given that we are already
changing collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607442)
Time Spent: 2.5h (was: 2h 20m)
> Infinite Redelivery could lead to extensive journal usage
> ---------------------------------------------------------
>
> Key: ARTEMIS-3261
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3261
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> In a situation the broker is misconfigured, and consumers redeliver forever
> without DLQ and Max Deliveries configured, the broker could get into a
> situation where the whole disk is exhausted.
>
> We should enhance compacting to cleanup records from rollback and updates
> that are no longer needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
