[
https://issues.apache.org/jira/browse/ARTEMIS-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361661#comment-17361661
]
ASF subversion and git services commented on ARTEMIS-3341:
----------------------------------------------------------
Commit a4c1155a013b015f53faca9f3558a081a1707491 in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a4c1155 ]
ARTEMIS-3341 update checkstyle to latest + update code
As a follow-up to #3618/dc7de893747b90b627d729f9f18a758bb4dad9d5 update
checkstyle to the latest version, restoring the originally intended
"RightCurly" style, and updating all the code to properly adhere to the
style as enforced by the new checkstyle version.
The version of checkstyle we used before the aforementioned commit had
a bug which didn't properly enforced our intended "RightCurly" style
(see https://github.com/checkstyle/checkstyle/issues/6345). That commit
changed the style to accommodate the handful of unintended style
violations. This commit reverts that change for 2 main reasons:
- The style was always intended to use `alone` for both `METHOD_DEF`
and `CTOR_DEF`.
- There are over 1,000 existing uses of the intended style and around
30 violations of this style which were unintentionally allowed.
Reverting the style back to the original and cleaning up the unintented
violations makes the code more consistent and prevents further style
inconsistencies in the future.
There were a handful of other changes related to checkstyle bugs which
allowed unintended style violations. These were related to indentation
levels.
This closes #3619
(with some minor changes from Robbie to fix remaining violations)
> update checkstyle, use consistent plugin version
> ------------------------------------------------
>
> Key: ARTEMIS-3341
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3341
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Update checkstyle. Use consistent plugin version. Some [trivial] code changes
> are made too due to updated behaviour, and also a config tweak to allow
> various existing "noOpMethod \{ }" instances to remain.
> This only updates to 8.29 rather the the latest, to get rid of the warning
> from GitHub for a CVE, per https://github.com/advisories/GHSA-763g-fqq7-48wg.
> Going to the newest versions will require more extensive changes to the code
> and/or config.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
