[
https://issues.apache.org/jira/browse/ARTEMIS-3356?focusedWorklogId=612016&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612016
]
ASF GitHub Bot logged work on ARTEMIS-3356:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/21 21:09
Start Date: 18/Jun/21 21:09
Worklog Time Spent: 10m
Work Description: michpetrov commented on a change in pull request #3629:
URL: https://github.com/apache/activemq-artemis/pull/3629#discussion_r653779705
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
##########
@@ -253,8 +253,8 @@ public synchronized PagedMessage readMessage(int
startOffset,
public synchronized List<PagedMessage> read(StorageManager storage, boolean
onlyLargeMessages) throws Exception {
if (logger.isDebugEnabled()) {
- logger.debugf("reading page %d on address = %s onlyLargeMessages =
%b", storeName, pageId,
- storage, onlyLargeMessages);
+ logger.debugf("reading page %d on address = %s onlyLargeMessages =
%b", new Object[] {pageId,
Review comment:
Otherwise I get a conflict because there are two methods with similar
signatures:
`debugf(String, int, Object, Object)`
`debugf(String, Object, Object, Object)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 612016)
Time Spent: 20m (was: 10m)
> Paging - wrong arguments in formatted message
> ---------------------------------------------
>
> Key: ARTEMIS-3356
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3356
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.17.0
> Reporter: Michal Petrov
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [Page.read()|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java#L255-L258]
> has wrong arguments declared in a formatted debug message. Throws
> {{java.util.IllegalFormatConversionException}} when debug is enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
