[
https://issues.apache.org/jira/browse/ARTEMIS-3372?focusedWorklogId=619092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-619092
]
ASF GitHub Bot logged work on ARTEMIS-3372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/21 11:15
Start Date: 06/Jul/21 11:15
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3640:
URL: https://github.com/apache/activemq-artemis/pull/3640#discussion_r663792385
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/management/OpenWireDeleteQueueTest.java
##########
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.openwire.management;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.Destination;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageListener;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.activemq.ActiveMQConnectionFactory;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.TransportConfiguration;
+import org.apache.activemq.artemis.api.core.management.ActiveMQServerControl;
+import org.apache.activemq.artemis.api.core.management.ObjectNameBuilder;
+import org.apache.activemq.artemis.core.config.Configuration;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import
org.apache.activemq.artemis.tests.integration.management.ManagementControlHelper;
+import org.apache.activemq.artemis.tests.integration.openwire.OpenWireTestBase;
+import org.apache.activemq.artemis.tests.util.Wait;
+import org.junit.Before;
+import org.junit.Test;
+
+public class OpenWireDeleteQueueTest extends OpenWireTestBase {
+
+ private ActiveMQServerControl serverControl;
+ private SimpleString queueName1 = new SimpleString("queue1");
+
+ private ConnectionFactory factory;
+
+ @Before
+ @Override
+ public void setUp() throws Exception {
+ super.setUp();
+ serverControl = (ActiveMQServerControl)
ManagementControlHelper.createProxy(ObjectNameBuilder.DEFAULT.getActiveMQServerObjectName(),
ActiveMQServerControl.class, mbeanServer);
+ factory = new ActiveMQConnectionFactory("failover:(" + urlString + ")");
+ }
+
+ @Override
+ protected void configureAddressSettings(Map<String, AddressSettings>
addressSettingsMap) {
+ addressSettingsMap.put("#", new
AddressSettings().setAutoCreateQueues(false).setAutoCreateAddresses(false).setDeadLetterAddress(new
SimpleString("ActiveMQ.DLQ")));
+ addressSettingsMap.put(queueName1.toString(), new
AddressSettings().setAutoCreateQueues(true).setAutoCreateAddresses(true).setDeadLetterAddress(new
SimpleString("ActiveMQ.DLQ")));
+
+ }
+
+ @Override
+ protected void extraServerConfig(Configuration serverConfig) {
+ serverConfig.setJMXManagementEnabled(true);
+ Set<TransportConfiguration> acceptorConfigs =
serverConfig.getAcceptorConfigurations();
+ for (TransportConfiguration tconfig : acceptorConfigs) {
+ if ("netty".equals(tconfig.getName())) {
+ Map<String, Object> params = tconfig.getExtraParams();
+ params.put("supportAdvisory", false);
+ params.put("suppressInternalManagementObjects", false);
+ }
+ }
+
+ }
+ @Test
+ public void testDestroyQueueClosingConsumers() throws Exception {
Review comment:
not sure, this problem is specific to openwire, the method was TODO and
the expectation from an openwire perspective is related to the auto queue
creation semantic and the shared view of both producers/consumers. Hense only
openwire needs to get a full disconnect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 619092)
Time Spent: 40m (was: 0.5h)
> Openwire - deleting a queue leaves consumers in limbo
> -----------------------------------------------------
>
> Key: ARTEMIS-3372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3372
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 2.17.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> openwire consumers are in limbo if a queue is deleted by a management
> operation.
> with activemq5 - any message sent will recreate the queue and the consumers
> will resume.
> however with Artemis, the send it to an address, independent of the consumer
> queue. The send will continue to drop messages till the binding/queue is
> recreated.
> Any openwire consumer disconnect (typical on queue deletion) needs to be
> implemented as connection error/fail to force a possible client failover
> event and a recreation of the queue/binding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
