[
https://issues.apache.org/jira/browse/ARTEMIS-3243?focusedWorklogId=619418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-619418
]
ASF GitHub Bot logged work on ARTEMIS-3243:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/21 15:23
Start Date: 06/Jul/21 15:23
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3633:
URL: https://github.com/apache/activemq-artemis/pull/3633#discussion_r664656198
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ProtonProtocolManager.java
##########
@@ -111,6 +116,15 @@ public ProtonProtocolManager(ProtonProtocolManagerFactory
factory, ActiveMQServe
this.updateInterceptors(incomingInterceptors, outgoingInterceptors);
}
+ public ReferenceIDSupplier getReferenceIDSupplier() {
+ if (referenceIDSupplier == null) {
+ // we lazy start the instance.
+ // only create it when needed
+ referenceIDSupplier = new ReferenceIDSupplier(server);
+ }
Review comment:
Also it seems like perhaps the above might even become possible before
the startup gets to the point of setting up the mirroring (as it starts
accepting before it starts the 'protocol services' that creates the mirror),
meaning they could all potentially happen concurrently even on a broker that is
configured to mirror.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 619418)
Time Spent: 12h 40m (was: 12.5h)
> Enhance AMQP Mirror support with dual mirror
> --------------------------------------------
>
> Key: ARTEMIS-3243
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3243
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.17.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> at the current Mirror version, we can only mirror into a single direction.
> With this enhancement the two (or more brokers) would be connected to each
> other, each one having its own ID, and each one would send updates to the
> other broker.
> The outcome is that if you just transferred producers and consumers from one
> broker into the other, the fallback would be automatic and simple. No need to
> disable and enable mirror options.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)