[
https://issues.apache.org/jira/browse/ARTEMIS-3397?focusedWorklogId=626406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626406
]
ASF GitHub Bot logged work on ARTEMIS-3397:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/21 02:56
Start Date: 22/Jul/21 02:56
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666#issuecomment-884623737
A few points...
1. The "rate" was never meant to be user facing. It was designed to be used
exclusively for slow-consumer detection (i.e.
`org.apache.activemq.artemis.core.server.impl.QueueImpl.SlowConsumerReaperRunnable`).
Calling it from other places can break slow-consumer detection and result in
false negatives. I made a mistake by adding `getRate()` to the
`org.apache.activemq.artemis.core.server.Queue` interface. It should always
have been `private`. I fixed that in this PR.
2. The "rate" was exposed originally on the web console by mistake via
[ARTEMIS-1349](https://issues.apache.org/jira/browse/ARTEMIS-1349) in 2.3.0. It
was likely included in
`org.apache.activemq.artemis.core.management.impl.view.QueueView` because
`getRate()` was on the `Queue` interface.
3. A corresponding JMX attribute was mistakenly added in 2.10.0 via
[ARTEMIS-2322](https://issues.apache.org/jira/browse/ARTEMIS-2322) and then
removed in 2.16.0 via
[ARTEMIS-2909](https://issues.apache.org/jira/browse/ARTEMIS-2909). I've heard
no complaints since then. I didn't even realize it was exposed on the web
console until recently otherwise I would have removed it when I removed the JMX
attribute.
4. I think it's unlikely that "rate" is widely used given it was never
properly documented and exhibits strange behavior (e.g. consecutive calls to
`getRate()` can return widely varying results unless the rate of production is
extremely consistent over time, especially if any other user or system is also
polling it).
5. Better alternatives exists as outlined in
246bf083914c7acbb05a7fe0904c471331242c39.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 626406)
Time Spent: 50m (was: 40m)
> Remove queue rate metric from web console
> -----------------------------------------
>
> Key: ARTEMIS-3397
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3397
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This is a follow-up from ARTEMIS-2322.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
