[
https://issues.apache.org/jira/browse/ARTEMIS-3399?focusedWorklogId=626998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626998
]
ASF GitHub Bot logged work on ARTEMIS-3399:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/21 04:50
Start Date: 23/Jul/21 04:50
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request #3669:
URL: https://github.com/apache/activemq-artemis/pull/3669
Due to the multi-threaded AMQP implementation the ThreadLocal variables
used by the AuditLogger to track the username and remote address don't
work properly. Changes include:
- Passing the audit Subject (set during authentication) and the remote
address explicitly for audit logging on the relevant ServerSession
methods rather than relying on the AuditLogger's ThreadLocal
variables
- Audit logging core session creation *after* successful authentication
so that we have the proper Subject; this is especially important for
the SSL certificate authentication use-case
- Renaming some methods and variables in AuditLogger to more accurately
reflect their intended use
- Adding JavaDoc and refactoring the getCaller methods on AuditLogger
- Refactor audit log testing and add a new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 626998)
Remaining Estimate: 0h
Time Spent: 10m
> Fix audit logging for AMQP
> --------------------------
>
> Key: ARTEMIS-3399
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3399
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Due to the multi-threaded AMQP implementation the {{ThreadLocal}} variables
> used by the {{AuditLogger}} to track the username and remote address don't
> work properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
