[
https://issues.apache.org/jira/browse/ARTEMIS-1925?focusedWorklogId=628939&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628939
]
ASF GitHub Bot logged work on ARTEMIS-1925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/21 09:10
Start Date: 28/Jul/21 09:10
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3676:
URL: https://github.com/apache/activemq-artemis/pull/3676#discussion_r678119987
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/MessageRedistributionTest.java
##########
@@ -730,6 +730,40 @@ public void testRedistributionWhenRemoteConsumerIsAdded()
throws Exception {
verifyNotReceive(1);
}
+ @Test
+ public void testRedistributionWhenRemoteConsumerIsAddedLbOff() throws
Exception {
+ setupCluster(MessageLoadBalancingType.OFF);
Review comment:
there are two features in play, the initial load balancing on routing,
and redistribution. The fact that they are currently intertwined is a bug, they
do different things, this is clear in the code and in the existing doc.
This change separates them further, and what breaks was already broken.
This is my read of what breaks:
enabling redistribution with redistribution-delay != -1 and then using
LoadBalanceType.OFF to disable redistribution!.
clearly, to disable redistribution, leave redistribution-delay at the
default of -1. ie: don't configure it in the first place.
The 'broken' case, which is just wrong, can be called out in the release
note.
this is a new test that captures the 'now' more clear separation of the
features, they are independent and useful when combined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 628939)
Time Spent: 6h (was: 5h 50m)
> Allow message redistribution even with STRICT or OFF message-load-balancing
> semantics
> -------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1925
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Currently if the {{message-load-balancing}} is {{STRICT}} or {{OFF}} then
> message redistribution is disabled. Message redistribution should be
> controlled only by the {{redistribtion-delay}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
