[
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=631133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-631133
]
ASF GitHub Bot logged work on AMQ-7309:
---------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jul/21 13:20
Start Date: 29/Jul/21 13:20
Worklog Time Spent: 10m
Work Description: mattrpav commented on pull request #682:
URL: https://github.com/apache/activemq/pull/682#issuecomment-889138211
> > Cool, what is the link to the test code? Test output?
>
> The test code is at
https://github.com/apache/qpid-jms/blob/1.1.0/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/producer/JmsMessageProducerTest.java#L177.
Its very simple, 'create foreign 5.x message object, try to send + receive
message'. It fails to send on line 200, due to JMSDeliveryTime UOE from the
message.
>
> For completeness, this is the change I made to try out the changes:
[gemmellr/qpid-jms@516462f](https://github.com/gemmellr/qpid-jms/commit/516462f9d177ab8d1ab48fe29555e464c172201f)
Without a stacktrace, I'm estimating that this is the method throwing the
exception:
```
JMSSession.java
private void setForeignMessageDeliveryTime(Message foreignMessage, long
deliveryTime) throws JMSException
```
Yeah, so in that code it could be argued that the 'hasDelay' marker variable
should be used before calling the setJMSDeliveryTime in the private
setForeignMessageDeliveryTime method. That method presumes that it should call
the setJMSDeliveryTime even if there hasn't been a DeliveryDelay specified.
Either approach (throw UOE or swallow expected Delivery Delays) will present
downside to varying users and interests.
I contend that the current UOE approach matches several project goals:
1. The implementation matches the description in the JIRA
2. The mailing list discussion has settled on this approach
3. The desire to keep PR changes concise
There is a dedicated JIRA for DeliveryDelay implentation discussion here:
[AMQ-8320](https://issues.apache.org/jira/browse/AMQ-8320)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 631133)
Time Spent: 6h 40m (was: 6.5h)
> Add JMS 2.0 support
> -------------------
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Broker, JMS client
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
