[
https://issues.apache.org/jira/browse/AMQ-8252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392764#comment-17392764
]
ASF subversion and git services commented on AMQ-8252:
------------------------------------------------------
Commit f7f52ccc7a7e7b0e95a760a4b63bc4429316b4e8 in activemq's branch
refs/heads/main from Jean-Baptiste Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=f7f52cc ]
Merge pull request #695 from jbonofre/AMQ-8252
[AMQ-8252] Doesn't display warn stack trace for stomp (regression compared to
5.15.x)
> Unnecessary stack trace in case of invalid credentials
> ------------------------------------------------------
>
> Key: AMQ-8252
> URL: https://issues.apache.org/jira/browse/AMQ-8252
> Project: ActiveMQ
> Issue Type: Bug
> Components: STOMP
> Affects Versions: 5.16.2
> Environment: ActiveMQ 5.16.2
> Reporter: Lionel Cons
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0, 5.16.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In case an invalid credential is used with STOMP, we get an unnecessary stack
> trace:
> {code}
> 2021-04-28T09:17:07.020+0200 [ActiveMQ NIO Worker 0] WARN TransportConnection
> - Failed to add Connection id=ID:foo-29852-1619594148588-1:17,
> clientId=ID:foo-29852-1619594148588-1:17, clientIP=tcp://10.0.0.1:50940 due
> to User name [system] or password is invalid.
> 2021-04-28T09:17:07.020+0200 [ActiveMQ NIO Worker 0] WARN Service - Security
> Error occurred on connection to: tcp://10.0.0.1:50940, User name [system] or
> password is invalid.
> 2021-04-28T09:17:07.029+0200 [ActiveMQ NIO Worker 0] WARN Transport -
> Transport Connection to: tcp://10.0.0.1:50940 failed
> java.io.IOException: User name [system] or password is invalid.
> at
> org.apache.activemq.util.IOExceptionSupport.create(IOExceptionSupport.java:40)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter$3.onResponse(ProtocolConverter.java:785)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter.onActiveMQCommand(ProtocolConverter.java:865)
> at
> org.apache.activemq.transport.stomp.StompTransportFilter.oneway(StompTransportFilter.java:72)
> at
> org.apache.activemq.transport.AbstractInactivityMonitor.doOnewaySend(AbstractInactivityMonitor.java:335)
> at
> org.apache.activemq.transport.AbstractInactivityMonitor.oneway(AbstractInactivityMonitor.java:317)
> at
> org.apache.activemq.transport.MutexTransport.oneway(MutexTransport.java:68)
> at
> org.apache.activemq.broker.TransportConnection.dispatch(TransportConnection.java:1480)
> at
> org.apache.activemq.broker.TransportConnection.processDispatch(TransportConnection.java:977)
> at
> org.apache.activemq.broker.TransportConnection.dispatchSync(TransportConnection.java:933)
> at
> org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:202)
> at
> org.apache.activemq.transport.MutexTransport.onCommand(MutexTransport.java:45)
> at
> org.apache.activemq.transport.AbstractInactivityMonitor.onCommand(AbstractInactivityMonitor.java:301)
> at
> org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:97)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:179)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter.onStompConnect(ProtocolConverter.java:777)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommand(ProtocolConverter.java:254)
> at
> org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:85)
> at
> org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:83)
> at
> org.apache.activemq.transport.stomp.StompCodec.processCommand(StompCodec.java:133)
> at
> org.apache.activemq.transport.stomp.StompCodec.parse(StompCodec.java:100)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport.processBuffer(StompNIOTransport.java:136)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport.serviceRead(StompNIOTransport.java:121)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport.access$000(StompNIOTransport.java:44)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport$1.onSelect(StompNIOTransport.java:73)
> at
> org.apache.activemq.transport.nio.SelectorSelection.onSelect(SelectorSelection.java:98)
> at
> org.apache.activemq.transport.nio.SelectorWorker$1.run(SelectorWorker.java:123)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.SecurityException: User name [system] or password is
> invalid.
> at
> org.apache.activemq.security.JaasAuthenticationBroker.authenticate(JaasAuthenticationBroker.java:97)
> at
> org.apache.activemq.security.JaasAuthenticationBroker.addConnection(JaasAuthenticationBroker.java:68)
> at
> org.apache.activemq.security.JaasDualAuthenticationBroker.addConnection(JaasDualAuthenticationBroker.java:94)
> at
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)
> at
> org.apache.activemq.plugin.AbstractRuntimeConfigurationBroker.addConnection(AbstractRuntimeConfigurationBroker.java:118)
> at
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)
> at
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)
> at
> org.apache.activemq.broker.TransportConnection.processAddConnection(TransportConnection.java:848)
> at
> org.apache.activemq.broker.jmx.ManagedTransportConnection.processAddConnection(ManagedTransportConnection.java:77)
> at
> org.apache.activemq.command.ConnectionInfo.visit(ConnectionInfo.java:139)
> at
> org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:331)
> at
> org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:200)
> ... 19 more
> Caused by: javax.security.auth.login.FailedLoginException: Password does not
> match
> at
> org.apache.activemq.jaas.PropertiesLoginModule.login(PropertiesLoginModule.java:95)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at javax.security.auth.login.LoginContext.invoke(LoginContext.java:755)
> at
> javax.security.auth.login.LoginContext.access$000(LoginContext.java:195)
> at javax.security.auth.login.LoginContext$4.run(LoginContext.java:682)
> at javax.security.auth.login.LoginContext$4.run(LoginContext.java:680)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:680)
> at javax.security.auth.login.LoginContext.login(LoginContext.java:587)
> at
> org.apache.activemq.security.JaasAuthenticationBroker.authenticate(JaasAuthenticationBroker.java:92)
> ... 30 more
> {code}
> This seems to be a regression because this problem was fixed as part of
> AMQ-7303.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
