[
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=633841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633841
]
ASF GitHub Bot logged work on AMQ-7309:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/21 21:30
Start Date: 04/Aug/21 21:30
Worklog Time Spent: 10m
Work Description: gemmellr commented on pull request #682:
URL: https://github.com/apache/activemq/pull/682#issuecomment-892988374
>
>
> What exactly is breaking? If we put a long in there, it’s a dead store.
It breaks being able to send any 5.x message through any JMS 2 provider that
implements what the spec says. Ones which worked before. Breaking.
Its not dead, its needed so that people can use the getter to see the
applied value after send. Its specifically what the methods exist for, and it
will need to be implemented at some point as its what those methods do. It
makes sense to do it now to avoid breaking things.
>
> The pre-openwire v13 change is to map to a property for the interim. See
the ticket specifically about DeliveryTime.
>
> My suggestion is to move forward with this set of changes and then I can
push the PR w the property-based DeliveryTime solution and this concern goes
away as DeliveryTime will be implemented.
This is a local change to the message object, no openwire changes needed. I
think it makes sense to do it here, given the discussion, and instead of
breaking it first unecessarily then fixing it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 633841)
Time Spent: 8.5h (was: 8h 20m)
> Add JMS 2.0 support
> -------------------
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Broker, JMS client
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
