[
https://issues.apache.org/jira/browse/ARTEMIS-3414?focusedWorklogId=635102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635102
]
ASF GitHub Bot logged work on ARTEMIS-3414:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 12:17
Start Date: 06/Aug/21 12:17
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3688:
URL: https://github.com/apache/activemq-artemis/pull/3688#discussion_r684189086
##########
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
##########
@@ -283,6 +283,12 @@
@Option(name = "--staticCluster", description = "Cluster node connectors
list, separated by comma: Example
\"tcp://server:61616,tcp://server2:61616,tcp://server3:61616\"")
String staticNode;
+ @Option(name = "--support-advisory", description = "Set
supportAdvisory=true for the main 'artemis' acceptor on OPENWIRE protocol
(Default: false)")
Review comment:
On Boolean values, the defaults are always false.
instead, please change the text as...
description = "If --support-advisory is used, the generated configuration
will allow advisories for the openwire protocol"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 635102)
Time Spent: 0.5h (was: 20m)
> Disable OpenWire advisory support as default created configuration on CLI
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-3414
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3414
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Supporting advisory for OpenWire has been in the past an ugly rabbit hole of
> both performance and stability issues, especially with clustering enabled:
> this one is a first step to help users to get a more stable broker while
> using CLI commands on broker instance creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
