[
https://issues.apache.org/jira/browse/ARTEMIS-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403913#comment-17403913
]
ASF subversion and git services commented on ARTEMIS-3440:
----------------------------------------------------------
Commit 5a1449d8127a11fb891819981739b04001d1d45b in activemq-artemis's branch
refs/heads/main from Robbie Gemmell
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=5a1449d ]
ARTEMIS-3440: separate effect of -Pdev from test profiles, make them independent
use pluginManagement config + executions to enable the RAT and Checkstyle
checks rather than properties
> separate effect of -Pdev from -Ptests
> -------------------------------------
>
> Key: ARTEMIS-3440
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3440
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the build has RAT and checkstyle executions always configured, but
> uses some artemis specific properties to skip them by default. These
> properties are then used in the 'tests', fast-tests', and 'dev' profiles to
> enable the checks when the profile is activated.
> This approach means that:
> - If you use the test profiles (needed to run tests), you get the dev checks
> even if you dont want.
> - You cant skip or not-skip the checks even with their own well known skip
> properties.
> - You cant run the check directly with its own mojo, without first hunting
> down an artemis specific property to also not-skip them so they actually run.
> The former in particular can be annoying when developing and running specific
> tests repeatedly, as it adds >10sec before the execution of a specified
> integration test for example.
> It also prevents an improvement I was looking to do for the GHA CI jobs where
> the checks are run in isolation from the tests (ensures the tests start and
> complete as fast as possible, speeding things up overall, makes the checks
> not prevent the tests running if they fail, and vice versa ensures the checks
> occur regardless of the tests failing which happens somewhat often at times).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
